Hello, Anna from Victoria

Hi @annark, welcome!

Thank you for offering to help. We appreciate it.

Combining Dataloader and Dataset into EnvironmentInterface sounds like a good project. Breaking that down into smaller chunks would be something along the lines of:

  • Move the four functions implemented in EnvironmentDataset into EnvironmentDataLoader.
  • Update the calls to those functions to reference the EnvironmentDataLoader instead.
  • Rename EnvironmentDataLoader to EnvironmentInterface, get rid of DataLoader language throughout.
  • Track down necessary configuration changes and ensure benchmarks all run with the same results (they currently double as end-to-end integration tests)
    • As long as your machine’s benchmarks are the same before and after, they don’t need to match our posted numbers. We can verify this later.
  • There are also likely documentation updates to make.

I hope that helps get you started.

Cheers,

Tristan

3 Likes